Tips & Tricks: статті за тегом «Чистий код»

// ПОГАНО
if (!User::where('email', $email)->exists()) {
  return response()->json(['error' => 'User not found'], 404);
}

// ДОБРЕ
User::where('email', $email)
  ->existsOr(function () {
    throw new UserNotFoundException('User not found');
  });

// Створити, якщо немає
Post::where('slug', $slug)
  ->existsOr(function () use ($slug) {
    Post::create(['slug' => $slug, 'title' => 'Draft']);
  });

// Лог при існуванні
Order::where('id', $orderId)
  ->where('status', 'pending')
  ->doesntExistOr(function () use ($orderId) {
    Log::warning("Non-pending order: {$orderId}");
  });

// ПОГАНО: ручний foreign key
$posts = Post::where('user_id', $user->id)->get();
$comments = Comment::where('post_id', $post->id)->get();

// ДОБРЕ: Laravel сам визначає ключ
$posts = Post::whereBelongsTo($user)->get();
$comments = Comment::whereBelongsTo($post)->get();

// Кілька зв'язків
$comments = Comment::whereBelongsTo($user)
  ->whereBelongsTo($post)
  ->get();

// Кастомна назва зв'язку
$posts = Post::whereBelongsTo($user, 'author')->get();

// У policy - максимально чисто
public function update(User $user, Post $post)
{
  return Post::whereBelongsTo($user)->exists();
}

use Illuminate\Database\Eloquent\Casts\Attribute;

class User extends Model
{
  // Accessor
  protected function name(): Attribute
  {
    return Attribute::make(
      get: fn($value) => ucfirst($value),
    );
  }

  // Mutator
  protected function password(): Attribute
  {
    return Attribute::make(
      set: fn($value) => bcrypt($value),
    );
  }

  // Обидва
  protected function firstName(): Attribute
  {
    return Attribute::make(
      get: fn($value) => ucfirst($value),
      set: fn($value) => strtolower($value),
    );
  }
}

// ПОГАНО
$query = User::query();
if ($request->status) {
  $query->where('status', $request->status);
}
if ($request->role) {
  $query->where('role', $request->role);
}
$users = $query->get();

// ДОБРЕ
$users = User::query()
  ->when($request->status,
    fn($q, $v) => $q->where('status', $v))
  ->when($request->role,
    fn($q, $v) => $q->where('role', $v))
  ->get();

// З "else"
$users = User::when(
  $request->sort === 'name',
  fn($q) => $q->orderBy('name'),
  fn($q) => $q->orderBy('created_at')
)->get();

// User Model
public function scopeActive($query)
{
  return $query->where('status', 'active');
}

public function scopeVerified($query)
{
  return $query->whereNotNull('email_verified_at');
}

public function scopeCreatedAfter($query, $date)
{
  return $query->where('created_at', '>', $date);
}

// Використання - чисто та читабельно
$users = User::active()->verified()->get();

$recentUsers = User::active()
  ->createdAfter(now()->subDays(7))
  ->get();

// Комбінування зі звичайними методами запиту
$admins = User::active()
  ->where('role', 'admin')
  ->orderBy('name')
  ->get();

// Модель User
public function scopeFilter($query, array $filters)
{
    return $query
        ->when($filters['status'] ?? false,
            fn($q, $status) => $q->where('status', $status))
        ->when($filters['role'] ?? false,
            fn($q, $role) => $q->where('role', $role))
        ->when($filters['search'] ?? false,
            fn($q, $search) => $q->where('name', 'like', "%{$search}%"))
        ->when($filters['date_from'] ?? false,
            fn($q, $date) => $q->whereDate('created_at', '>=', $date))
        ->when($filters['date_to'] ?? false,
            fn($q, $date) => $q->whereDate('created_at', '<=', $date));
}

// Контролер - чисто і просто
public function index(Request $request)
{
    return User::filter($request->only([
        'status', 'role', 'search', 'date_from', 'date_to'
    ]))->paginate();
}